Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest-api-client): support getSpace API #2582

Merged
merged 8 commits into from
Feb 26, 2024
Merged

feat(rest-api-client): support getSpace API #2582

merged 8 commits into from
Feb 26, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented Feb 22, 2024 •
edited
Loading

Why

  • Support getSpace API to be able to get space information.

What

  • Add new category of API (space)
  • Add new method getspace
  • Add unit test for getSpace

How to test

  • Check test spec

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team February 22, 2024 07:29
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Feb 22, 2024
@tuanphamcybozu tuanphamcybozu changed the title feat(rest-api-client): support getSpace api feat(rest-api-client): support getSpace API Feb 22, 2024
tasshi-me
tasshi-me reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some request to change.
Please check it out!

packages/rest-api-client/docs/space.md Outdated Show resolved Hide resolved
packages/rest-api-client/src/client/types/index.ts Outdated Show resolved Hide resolved
packages/rest-api-client/src/client/types/space/index.ts Outdated Show resolved Hide resolved
packages/rest-api-client/src/client/types/space/index.ts Outdated Show resolved Hide resolved
packages/rest-api-client/src/client/SpaceClient.ts Show resolved Hide resolved
tasshi-me
tasshi-me requested changes Feb 26, 2024
View reviewed changes
packages/rest-api-client/docs/space.md Outdated Show resolved Hide resolved
@tasshi-me tasshi-me merged commit e417752 into master Feb 26, 2024
10 checks passed
@tasshi-me tasshi-me deleted the feat/support-getSpace-api branch February 26, 2024 23:01
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@hung-cybo hung-cybo Awaiting requested review from hung-cybo

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuanphamcybozu @tasshi-me