Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(create-plugin): add test case for JsSdkTest-9 #2738

Merged
merged 2 commits into from
May 6, 2024
Merged

test(create-plugin): add test case for JsSdkTest-9 #2738

merged 2 commits into from
May 6, 2024

Conversation

hung-cybo
Copy link
Contributor

Why

  • Increase the reliability of create-plugin package.

What

  • Add test case JsSdkTest-9

How to test

pnpm test:e2e

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@hung-cybo hung-cybo requested review from a team and minh-nguyen1985 and removed request for a team May 3, 2024 09:43
@github-actions github-actions bot added the pkg: create-plugin @kintone/create-plugin label May 3, 2024
@aws-amplify-ap-northeast-1 AWS Amplify (ap-northeast-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2738.d1ite8zvzg8c5i.amplifyapp.com

@hung-cybo hung-cybo changed the title test: add test case for JsSdkTest-9 test(create-plugin): add test case for JsSdkTest-9 May 3, 2024
tuanphamcybozu
tuanphamcybozu approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuanphamcybozu tuanphamcybozu merged commit 4f96f69 into master May 6, 2024
18 checks passed
@tuanphamcybozu tuanphamcybozu deleted the test/JsSdkTest-9 branch May 6, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuanphamcybozu tuanphamcybozu tuanphamcybozu approved these changes

@minh-nguyen1985 minh-nguyen1985 Awaiting requested review from minh-nguyen1985

Assignees
No one assigned
Labels
pkg: create-plugin @kintone/create-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hung-cybo @tuanphamcybozu