Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest-api-client): update space.getSpace method #2876

Merged
merged 6 commits into from
Jul 25, 2024
Merged

feat(rest-api-client): update space.getSpace method #2876

merged 6 commits into from
Jul 25, 2024

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 12, 2024 •
edited
Loading

Why

With the official release of the June 2024 version, the 'permissions' parameter was added in the response body of Get Space API.

What

  • Update the type of Space to add 'permissions' parameter.
    • In addition, the following parameters were missing, so they were also added to the type definition:
      • showAnnouncement
      • showThreadList
      • showAppList
      • showMemberList
      • showRelatedLinkList
  • update doc for space.getSpace.

How to test

  1. Create a space on UI.
  2. Exec space.getSpace method
  3. Check to include the permissions parameter in the response
  4. Check to be able to access permissions parameter of the value of the response.

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jul 12, 2024
@shabaraba shabaraba force-pushed the feat/update-get-space-method branch from 7070889 to 3422585 Compare July 12, 2024 08:02
@shabaraba shabaraba marked this pull request as ready for review July 12, 2024 13:14
@shabaraba shabaraba requested a review from tasshi-me July 17, 2024 00:23
tasshi-me
tasshi-me requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1箇所だけ変更依頼を追加しました！

packages/rest-api-client/src/client/types/space/index.ts Show resolved Hide resolved
packages/rest-api-client/src/client/types/space/index.ts Outdated Show resolved Hide resolved
@shabaraba
Copy link
Member Author

@tasshi-me
ありがとうございます、見逃していました 🙇

@shabaraba shabaraba requested a review from tasshi-me July 17, 2024 05:54
tasshi-me
tasshi-me approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shabaraba shabaraba merged commit 8ecc4d1 into main Jul 25, 2024
17 checks passed
@shabaraba shabaraba deleted the feat/update-get-space-method branch July 25, 2024 04:27
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shabaraba @tasshi-me