Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 maintenance: Lasio: part 1 #566

Merged

Conversation

dcslagel
Copy link
Collaborator

@dcslagel dcslagel commented Mar 2, 2023

Description:

This change covers flake8 changes for the first of the Lasio files.
This is part of Flake8 maintenance for Lasio code #564

  • lasio/examples.py
  • lasio/excel.py

This pull request makes changes suggested by flake8.

encoding.py

examples.py:81:30: F821 undefined name 'encoding_kwargs'
examples.py:82:28: F821 undefined name 'encoding_kwargs'

excel.py

excel.py:106:5: E741 ambiguous variable name 'l'
excel.py:135:17: E741 ambiguous variable name 'l'
excel.py:138:13: E722 do not use bare 'except'

Test Results

Name                       Stmts   Miss  Cover
----------------------------------------------
lasio/__init__.py             28      6    79%
lasio/convert_version.py      20     20     0%
lasio/defaults.py             12      0   100%
lasio/examples.py             42     10    76%
lasio/excel.py                88     34    61%
lasio/exceptions.py            6      0   100%
lasio/las.py                 495     63    87%
lasio/las_items.py           220     30    86%
lasio/las_version.py          69     23    67%
lasio/reader.py              470     19    96%
lasio/writer.py              200      9    96%
----------------------------------------------
TOTAL                       1650    214    87%
Coverage XML written to file coverage.xml



--------------------------------------------------- benchmark: 1 tests --------------------------------------------------
Name (time in ms)                 Min       Max      Mean  StdDev    Median     IQR  Outliers     OPS  Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------
test_read_v12_sample_big     125.2639  126.7751  125.8339  0.4944  125.7579  0.6141       3;0  7.9470       8           1
-------------------------------------------------------------------------------------------------------------------------

--

Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.

Thank you,
DC

- examples.py
- excel.py
@kinverarity1 kinverarity1 merged commit 52c02ca into kinverarity1:main Mar 3, 2023
@dcslagel dcslagel deleted the flake8-maintenance-lasio-01 branch March 3, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants