pkg/components: remove Register(), Get() and other related functions

They are not used anymore, so can be removed. Refs #992. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
kinvolk · Dec 2, 2020 · 4a3ca24 · 4a3ca24
1 parent a32721e
commit 4a3ca24
Show file tree

Hide file tree

Showing 22 changed files with 0 additions and 121 deletions.
diff --git a/pkg/components/aws-ebs-csi-driver/component.go b/pkg/components/aws-ebs-csi-driver/component.go
@@ -36,11 +36,6 @@ enableDefaultStorageClass: {{ .EnableDefaultStorageClass }}
 `
 )
 
-//nolint:gochecknoinits
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	EnableDefaultStorageClass bool `hcl:"enable_default_storage_class,optional"`
 }

diff --git a/pkg/components/cert-manager/component.go b/pkg/components/cert-manager/component.go
@@ -32,10 +32,6 @@ const (
 	Name = "cert-manager"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	Email          string `hcl:"email,attr"`
 	Namespace      string `hcl:"namespace,optional"`

diff --git a/pkg/components/cluster-autoscaler/component.go b/pkg/components/cluster-autoscaler/component.go
@@ -78,10 +78,6 @@ serviceMonitor:
 `
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	// required parameters
 	Provider    string `hcl:"provider,optional"`

diff --git a/pkg/components/components.go b/pkg/components/components.go
@@ -15,44 +15,13 @@
 package components
 
 import (
-	"fmt"
 	"path/filepath"
 
 	"github.com/kinvolk/lokomotive/pkg/assets"
 	"github.com/kinvolk/lokomotive/pkg/helm"
 	"helm.sh/helm/v3/pkg/chart"
 )
 
-// components is the map of registered components
-var components map[string]Component
-
-func init() {
-	components = make(map[string]Component)
-}
-
-func Register(name string, obj Component) {
-	if _, exists := components[name]; exists {
-		panic(fmt.Sprintf("component with name %q registered already", name))
-	}
-	components[name] = obj
-}
-
-func ListNames() []string {
-	var componentList []string
-	for name := range components {
-		componentList = append(componentList, name)
-	}
-	return componentList
-}
-
-func Get(name string) (Component, error) {
-	component, exists := components[name]
-	if !exists {
-		return nil, fmt.Errorf("no component with name %q found", name)
-	}
-	return component, nil
-}
-
 // Chart is a convenience function which returns a pointer to a chart.Chart representing the
 // component named name.
 func Chart(name string) (*chart.Chart, error) {

diff --git a/pkg/components/contour/component.go b/pkg/components/contour/component.go
@@ -35,10 +35,6 @@ const (
 	serviceTypeLoadBalancer = "LoadBalancer"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 // This annotation is added to Envoy service.
 type component struct {
 	EnableMonitoring bool                `hcl:"enable_monitoring,optional"`

diff --git a/pkg/components/dex/component.go b/pkg/components/dex/component.go
@@ -33,10 +33,6 @@ const (
 	Name = "dex"
 )
 
-func init() { //nolint:gochecknoinits
-	components.Register(Name, NewConfig())
-}
-
 type org struct {
 	Name  string   `hcl:"name,attr" json:"name"`
 	Teams []string `hcl:"teams,attr" json:"teams"`

diff --git a/pkg/components/external-dns/component.go b/pkg/components/external-dns/component.go
@@ -65,10 +65,6 @@ metrics:
 `
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 // AwsConfig provides configuration for AWS Route53 DNS.
 type AwsConfig struct {
 	ZoneID          string `hcl:"zone_id"`

diff --git a/pkg/components/flatcar-linux-update-operator/component.go b/pkg/components/flatcar-linux-update-operator/component.go
@@ -31,10 +31,6 @@ const (
 	Name = "flatcar-linux-update-operator"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 // NewConfig returns new Flatcar Linux Update Operator component configuration with default values set.
 //
 //nolint:golint

diff --git a/pkg/components/gangway/component.go b/pkg/components/gangway/component.go
@@ -32,10 +32,6 @@ const (
 	Name = "gangway"
 )
 
-func init() { //nolint:gochecknoinits
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	ClusterName              string `hcl:"cluster_name,attr"`
 	IngressHost              string `hcl:"ingress_host,attr"`

diff --git a/pkg/components/httpbin/component.go b/pkg/components/httpbin/component.go
@@ -32,10 +32,6 @@ const (
 	Name = "httpbin"
 )
 
-func init() { //nolint:gochecknoinits
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	IngressHost              string `hcl:"ingress_host,attr"`
 	CertManagerClusterIssuer string `hcl:"certmanager_cluster_issuer,optional"`

diff --git a/pkg/components/inspektor-gadget/component.go b/pkg/components/inspektor-gadget/component.go
@@ -32,11 +32,6 @@ const (
 	Name = "inspektor-gadget"
 )
 
-//nolint:gochecknoinits
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	Namespace       string `hcl:"namespace,optional"`
 	EnableTraceloop bool   `hcl:"enable_traceloop,optional"`

diff --git a/pkg/components/istio-operator/component.go b/pkg/components/istio-operator/component.go
@@ -34,11 +34,6 @@ const (
 	namespace = "istio-operator"
 )
 
-//nolint:gochecknoinits
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	Profile          string `hcl:"profile,optional"`
 	EnableMonitoring bool   `hcl:"enable_monitoring,optional"`

diff --git a/pkg/components/linkerd/component.go b/pkg/components/linkerd/component.go
@@ -38,11 +38,6 @@ const (
 	certCommonName = "identity.linkerd.cluster.local"
 )
 
-//nolint:gochecknoinits
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	ControllerReplicas int    `hcl:"controller_replicas,optional"`
 	EnableMonitoring   bool   `hcl:"enable_monitoring,optional"`

diff --git a/pkg/components/metallb/component.go b/pkg/components/metallb/component.go
@@ -32,10 +32,6 @@ const (
 	Name = "metallb"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	AddressPools            map[string][]string `hcl:"address_pools"`
 	ControllerNodeSelectors map[string]string   `hcl:"controller_node_selectors,optional"`

diff --git a/pkg/components/metrics-server/component.go b/pkg/components/metrics-server/component.go
@@ -52,10 +52,6 @@ args:
 - --kubelet-preferred-address-types=InternalIP
 `
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	Namespace string `hcl:"namespace,optional"`
 }

diff --git a/pkg/components/openebs-operator/component.go b/pkg/components/openebs-operator/component.go
@@ -32,10 +32,6 @@ const (
 	Name = "openebs-operator"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	NDMSelectorLabel string `hcl:"ndm_selector_label,optional"`
 	NDMSelectorValue string `hcl:"ndm_selector_value,optional"`

diff --git a/pkg/components/openebs-storage-class/component.go b/pkg/components/openebs-storage-class/component.go
@@ -34,10 +34,6 @@ const (
 	poolName = "openebs-storage-pool"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type Storageclass struct {
 	Name         string   `hcl:"name,label"`
 	ReplicaCount int      `hcl:"replica_count,optional"`

diff --git a/pkg/components/prometheus-operator/component.go b/pkg/components/prometheus-operator/component.go
@@ -34,10 +34,6 @@ const (
 	Name = "prometheus-operator"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 // Monitor holds information about which Kubernetes components should be monitored with the default Prometheus instance.
 type Monitor struct {
 	Etcd                  bool `hcl:"etcd,optional"`

diff --git a/pkg/components/rook-ceph/component.go b/pkg/components/rook-ceph/component.go
@@ -32,10 +32,6 @@ const (
 	Name = "rook-ceph"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	Namespace      string              `hcl:"namespace,optional"`
 	MonitorCount   int                 `hcl:"monitor_count,optional"`

diff --git a/pkg/components/rook/component.go b/pkg/components/rook/component.go
@@ -33,10 +33,6 @@ const (
 	Name = "rook"
 )
 
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type component struct {
 	Namespace                string            `hcl:"namespace,optional"`
 	NodeSelector             util.NodeSelector `hcl:"node_selector,optional"`

diff --git a/pkg/components/velero/component.go b/pkg/components/velero/component.go
@@ -36,11 +36,6 @@ const (
 	Name = "velero"
 )
 
-// init registers velero component to components list, so it shows up as available to install
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 // component represents component configuration data
 type component struct {
 	// Namespace where velero resources should be installed. Defaults to 'velero'.

diff --git a/pkg/components/web-ui/component.go b/pkg/components/web-ui/component.go
@@ -33,11 +33,6 @@ const (
 	Name = "web-ui"
 )
 
-//nolint:gochecknoinits
-func init() {
-	components.Register(Name, NewConfig())
-}
-
 type oidc struct {
 	ClientID     string `hcl:"client_id"`
 	ClientSecret string `hcl:"client_secret"`