This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Create PoC for Lokomotive on AKS #216

Closed

invidian opened this issue Mar 25, 2020 · 3 comments

Assignees

Labels

Milestone

Member

invidian commented Mar 25, 2020

As first step towards #215

invidian self-assigned this

invidian mentioned this issue

Add ability to provide oidc configuration #182

Merged

2 tasks

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

adf8a2a

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

ae81f38

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

e5754bc

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

cd3961e

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian mentioned this issue

Add AKS platform support #219

Merged

14 tasks

invidian added a commit that referenced this issue


          Add AKS platform support

3b53c05

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

6f9c99a

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

5944be8

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

8242d2d

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

67c1202

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

ebcf2e3

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

Member Author

invidian commented Mar 27, 2020

If you're interested in progress on this, I report most in the associated PR: #219.

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

3ff2ae9

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

3ee890a

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

4b4455a

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

fde514d

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

iaguis added this to the v0.2.0 milestone

invidian added a commit that referenced this issue


          Add AKS platform support

96bc136

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

ebe1ed1

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

53d4891

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

73a72d9

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

7b90aa6

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

f249636

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

f785917

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

38b17cf

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

14d7a60

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

a08bbd7

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

842e5ef

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

ad02c23

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

8c5c047

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

bb308e8

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

6e73f00

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

4ace114

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

a1a5b4e

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

dd9d6b1

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

74c9d3a

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

a915e4e

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

9ceac6d

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

c23eff0

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

d26755b

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

2a9f305

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

38411b7

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

iaguis added the kind/roadmap label

iaguis mentioned this issue

Support Lokomotive on managed platforms #215

Closed

5 tasks

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

65fd0c0

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

4d8ad60

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

10f2dbc

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

ba02c21

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: aggregate getters into Meta() function

cc8cafa

So adding new properties does not require adding new interface method
and implementing it for all platforms.

This is required, as for adding support for managed Kubernetes
platforms, we will need to add more fields here.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          pkg/platform: add Managed field to Meta struct

72ae0f2

This field will be used to distinguished managed and self-hosted
platforms, as the cluster upgrade process will depend on this
information.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          cli/cmd/cluster-apply.go: don't try to upgrade managed platforms

If we deploy on managed Kubernetes, it won't have controlplane installed
as Helm releases, so we shouldn't try to upgrade it. The upgrade will be
most likely driven by Terraform.

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

invidian added a commit that referenced this issue


          Add AKS platform support

dd8f6ee

Refs #215 #216

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>

Contributor

iaguis commented Apr 27, 2020

This is merged.

iaguis closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.