This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
test/*: de-duplicate value timeout and retryInterval #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
force-pushed
the
knrt10/de-duplicate-timeout-retry-tests
branch
from
eff647f
to
584e827
Compare
invidian
suggested changes
Oct 7, 2020
|
There are 2 different values for timeout, 1 is 7min and other is 9 min. What should be the naming convention? TimeoutSlow and TimeoutSlower? |
7 minutes can either be left as-is (as there is no duplication) or just increased to 9 minutes. |
knrt10
force-pushed
the
knrt10/de-duplicate-timeout-retry-tests
branch
from
584e827
to
85fd4b8
Compare
knrt10
changed the title
knrt10
changed the title
knrt10
force-pushed
the
knrt10/de-duplicate-timeout-retry-tests
branch
2 times, most recently
from
453f775
to
625abe5
Compare
invidian
suggested changes
Oct 7, 2020
knrt10
force-pushed
the
knrt10/de-duplicate-timeout-retry-tests
branch
from
625abe5
to
c6434ff
Compare
timeout and retryInterval were same for most of the components and was duplicated. closes: #502 Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/de-duplicate-timeout-retry-tests
branch
from
c6434ff
to
d39fc22
Compare
invidian
approved these changes
Oct 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeout and retryInterval were the same for most of the components and was
duplicated.
closes: #502
Signed-off-by: knrt10 kautilya@kinvolk.io