This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 9, 2021 08:19
0c504a9
to
01b3aee
Compare
surajssd
suggested changes
Feb 9, 2021
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 9, 2021 09:45
01b3aee
to
1fdf035
Compare
invidian
reviewed
Feb 9, 2021
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 11, 2021 06:52
1fdf035
to
72eab4f
Compare
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 11, 2021 09:50
72eab4f
to
d885ed2
Compare
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 11, 2021 16:11
d885ed2
to
eae87cd
Compare
invidian
previously approved these changes
Feb 11, 2021
knrt10
suggested changes
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT, rest LGTM
knrt10
reviewed
Feb 12, 2021
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 12, 2021 06:56
eae87cd
to
0f63b03
Compare
knrt10
suggested changes
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small NIT
knrt10
reviewed
Feb 12, 2021
Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
release-v0.6.1
branch
from
February 12, 2021 07:14
0f63b03
to
d34473b
Compare
knrt10
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
surajssd
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Lokomotive 0.6.1 release.