-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
|
f82a7bf
to
a22acfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some doc changes, right? Otherwise it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My questions from #1003 (comment) are still applicable. IMO this change lacks the reasoning behind.
I'd say let's add same functionality and change the default for OpenEBS too and explain the reasoning, e.g. to avoid possibly surprising data loss when deleting the component. |
The component like |
Right, components (or even user apps) using storage. |
I'm a bit skeptical about changing the Kubernetes default, which I'd hope be more thoroughly selected. I don't mind making the reclaim policy customizable for components or even as default for storage class. |
a22acfa
to
97573d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
docs/configuration-reference/components/openebs-storage-class.md
Outdated
Show resolved
Hide resolved
97573d1
to
1eaf280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- Change the default behaviour of rook-ceph storage class to `Retain` from `Delete`, so if a user accidentally deletes a PVC they don't lose all the data in it. - Add a parameter `reclaim_policy` to `storage_class` block, to let user override the default behaviour. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
- Change the default behaviour of openebs-storage-class storage class to `Retain` from `Delete`, so if a user accidentally deletes a PVC they don't lose all the data in it. - Add a parameter `reclaim_policy` to `storage_class` block, to let user override the default behaviour. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
- Change the default behaviour of aws-ebs-csi-driver storage class to `Retain` from `Delete`, so if a user accidentally deletes a PVC they don't lose all the data in it. - Add a parameter `reclaim_policy` to `storage_class` block, to let user override the default behaviour. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
The default reclaim policy is set to Retain if the PVs are not deleted explicitly by the user they might remain around costing money. This change is introduced to reduce the proliferation of unused PVs that might be left as a result of multiple CI runs. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
1eaf280
to
237560a
Compare
Retain
from
Delete
.reclaim_policy
tostorage_class
block, to let useroverride the default behaviour.
Fixes: #1003