This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Remove the Webhook setting of cert-manager #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
previously approved these changes
Mar 4, 2021
meyskens
changed the title
meyskens
force-pushed
the
meyskens/rm-cm-no-webhook
branch
from
efe9dc4
to
da01fa0
Compare
invidian
previously approved these changes
Mar 4, 2021
surajssd
reviewed
Mar 8, 2021
meyskens
force-pushed
the
meyskens/rm-cm-no-webhook
branch
from
da01fa0
to
097bfb0
Compare
invidian
previously approved these changes
Mar 8, 2021
ipochi
previously approved these changes
Mar 8, 2021
|
re-running the failed CI jobs. |
surajssd
previously approved these changes
Mar 9, 2021
added 3 commits
March 29, 2021 09:51
The no-webhook version was removed since 0.15, this flag became non functional since then and will always install the webhook Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>
Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>
Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>
meyskens
force-pushed
the
meyskens/rm-cm-no-webhook
branch
from
097bfb0
to
71c668b
Compare
|
Rebased on master to have some CI fixes in the branch |
invidian
approved these changes
Apr 1, 2021
iaguis
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Webhook settiing of cert-manager
This removes the webhook flag from the cert-manager component as it did not function any longer. The no webhook version no longer exists.
How to use
Testing done
Notes
So removing the HCL flag might need some upgrade path, keeping it draft for now till I worked that out :) Just a quick patch in between other work.As discussed in Slack removing the flag is fine pre-1.0 , should be released in a new minor release with a note however.