This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
suggested changes
Jun 16, 2021
surajssd
force-pushed
the
surajssd/update-rook
branch
4 times, most recently
from
June 21, 2021 12:09
6f4014c
to
4637242
Compare
ipochi
reviewed
Jun 23, 2021
ipochi
previously approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Release Notes: https://github.com/rook/rook/releases/tag/v1.6.5. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This commit changes the default file system type to `ext4` from `xfs`. The rook documentation cautions: > `xfs` is not recommended due to potential deadlock in hyperconverged > settings where the volume is mounted on the same node as the osds. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This daemon was enabled by default before, but now the default has reversed. This commit ensures that the daemon is enabled. It is recommended to keep it enabled in the baremetal setup. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-rook
branch
from
June 24, 2021 09:42
4637242
to
9b38613
Compare
ipochi
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
invidian
added
area/components
Items related to components
area/dependency-update
To label pending updates of upstream projects
labels
Jul 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/components
Items related to components
area/dependency-update
To label pending updates of upstream projects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494