Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

refactor prometheus test code #185

Merged
merged 2 commits into from
Mar 20, 2020
Merged

refactor prometheus test code #185

merged 2 commits into from
Mar 20, 2020

Commits on Mar 19, 2020

  1. e2e: Invoke monitoring tests from single location 

    This commit adds a test function which initialises the prometheus client
and then passes it to the prometheus tests that need it.

This approach is preferable over creating a new port-forward for every
test is because initialising a port forward takes around 3-4 seconds and
this can significantly increase the total running time of tests. Reusing
port forward connection and prometheus client saves time for test.

And having a single place of creating port forward and client
intialisation ensures that we close that connection gracefully.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
    @surajssd
    surajssd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    3cc4263 View commit details
    Browse the repository at this point in the history

  2. e2e: Remove the code to initialise prom client 

    Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
    @surajssd
    surajssd committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    c44f61a View commit details
    Browse the repository at this point in the history