This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Label service-monitors so that they are discovered by Prometheus #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like help testing three components if they are creating ServiceMonitors:
|
|
TODOs:
|
invidian
reviewed
Mar 19, 2020
| @@ -88,6 +96,9 @@ type component struct { | |||
| ScaleDownUnreadyTime time.Duration | |||
| ScaleDownUnreadyTimeRaw string `hcl:"scale_down_unready_time,optional"` | |||
|
|
|||
| // Prometheus parameters | |||
There was a problem hiding this comment.
Suggested change
| // Prometheus parameters | |
| // Prometheus parameters. |
There was a problem hiding this comment.
none of the comments above have full stops, is it an uneven thing to add full stop only here?
There was a problem hiding this comment.
https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences we could rephrase to full sentence :)
surajssd
force-pushed
the
surajssd/update-servicemonitors
branch
from
59eec37
to
a69d30b
Compare
Make sure that the ServiceMonitor is selected to be monitored by the prometheus operator shipped with Lokomotive. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Make sure that the ServiceMonitors created for contour are selected by the prometheus operator shipped with Lokomotive. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Make sure that the ServiceMonitor created for velero is selected by the prometheus operator shipped with Lokomotive. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
* This variable will enable or disable creation of `ServiceMonitor` for cert-manager. * This commit also adds a label makes sure that the `ServiceMonitor` created for cert-manager is selected by the prometheus operator shipped with Lokomotive. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
* This variable will enable or disable creation of `ServiceMonitor` for cluster autoscaler. * This commit also adds a label makes sure that the `ServiceMonitor` created for cluster autoscaler is selected by the prometheus operator shipped with Lokomotive. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
* This variable will enable or disable creation of `ServiceMonitor` for external DNS. * This commit also adds a label makes sure that the `ServiceMonitor` created for external DNS is selected by the prometheus operator shipped with Lokomotive. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-servicemonitors
branch
4 times, most recently
from
df60a91
to
c66eadd
Compare
surajssd
force-pushed
the
surajssd/update-servicemonitors
branch
4 times, most recently
from
3299255
to
5150f00
Compare
surajssd
force-pushed
the
surajssd/update-servicemonitors
branch
2 times, most recently
from
9e91375
to
f866828
Compare
invidian
reviewed
Mar 25, 2020
test/components/util/util.go
Outdated
| } | ||
|
|
||
| // The platform should be present in the list of supported platforms. | ||
| if strings.Contains(platforms, platform) { |
There was a problem hiding this comment.
What about packet and packer-arm? If run on packet and test is only intended to run on packet-arm, it will be incorrectly triggered.
There was a problem hiding this comment.
Also it could be just return strings.Contains(platforms, platform).
There was a problem hiding this comment.
Yeah this is possible, but all the tests that run on packet-arm run on packet. It is super set of the other.
There was a problem hiding this comment.
This may produce unexpected behavior in some cases, that's not good :/
| { | ||
| componentName: "contour", | ||
| query: "contour_dagrebuild_timestamp", | ||
| platforms: "packet,aws", |
There was a problem hiding this comment.
This way it is easier for the user writing test.
There was a problem hiding this comment.
We could use strings for all values when programming, but it's generally not a good idea 😄
This commit adds a function which verifies if the platform on which this test is running is supported to run test. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This exports a variable for the post e2e tests. This variable specifies the current platform which will be used to detect if the corresponding component test we are running is supposed to be run on that platform or not. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Install components in following order, mandatorily, to ensure that other components can install Prometheus Operator CRs like ServiceMonitor and PrometheusRule: - OpenEBS - OpenEBS Storage Class - Prometheus Operator Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Install components in following order, mandatorily, to ensure that other components can install Prometheus Operator CRs like ServiceMonitor and PrometheusRule: - OpenEBS - OpenEBS Storage Class - Prometheus Operator Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-servicemonitors
branch
from
f866828
to
08b9132
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds labels to the ServiceMonitors that are shipped by default by the components. And few components were missing the config
service_monitorbool which is added.The components that ship ServiceMonitor and are labelled as follows.