This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
components/external-dns: expose owner_id #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
requested review from
invidian,
ipochi,
johananl,
pothos and
surajssd
as code owners
invidian
suggested changes
Mar 23, 2020
We were setting it to the AWS DNS Zone ID and that means that several clusters using the same DNS Zone will interact badly with each other. This exposes it to the user so they can choose a reasonable ID.
iaguis
force-pushed
the
iaguis/external-dns-owner
branch
from
f18706f
to
0b22acc
Compare
invidian
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting it to the AWS DNS Zone ID and that means that several
clusters using the same DNS Zone will interact badly with each other.
This exposes it to the user so they can choose a reasonable ID.