This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
suggested changes
Mar 26, 2020
assets/lokomotive-kubernetes/aws/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
Show resolved
Hide resolved
Changelog: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#v1180 Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-k8s-1.18
branch
2 times, most recently
from
March 26, 2020 11:11
fcbd39e
to
8988faa
Compare
This commit changes the apiserver configs to use the dedicated apiserver container image instead of using hyperkube image. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-k8s-1.18
branch
2 times, most recently
from
March 26, 2020 13:22
3dbec5a
to
0b69928
Compare
This commit changes the controller-manager configs to use the dedicated controller-manager container image instead of using hyperkube image. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-k8s-1.18
branch
from
March 26, 2020 14:31
0b69928
to
c30d87f
Compare
This commit changes the kube-scheduler configs to use the dedicated kube-scheduler container image instead of using hyperkube image. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-k8s-1.18
branch
from
March 26, 2020 15:04
c30d87f
to
012e207
Compare
This commit changes the kube-proxy configs to use the dedicated kube-proxy container image instead of using hyperkube image. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-k8s-1.18
branch
from
March 26, 2020 15:47
012e207
to
a226fcf
Compare
invidian
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me.
If you folks are ok with using that image then I can change that in this PR as well?
Can you please create an issue to discuss it? I think we should be maintaining our own image, if that's really needed.
mauriciovasquezbernal
added a commit
that referenced
this pull request
Apr 2, 2020
Follow up from #217.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that is not done in this PR is changing the images of kubelet. Kubelet is still provisioned using hyperkube. Upstream will stop shipping any image for kubelet. We need to build and maintain images for kubelet or we can use the images that are built for typhoon:
quay.io/poseidon/kubelet:v1.17.4
.If you folks are ok with using that image then I can change that in this PR as well?