Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

docs: Add instructions to run conformance tests #236

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Apr 1, 2020

Fixes #89

@surajssd surajssd requested a review from johananl as a code owner April 1, 2020 08:42
@surajssd surajssd requested a review from iaguis April 1, 2020 08:42
docs/run-conformance-tests.md Outdated Show resolved Hide resolved
docs/run-conformance-tests.md Outdated Show resolved Hide resolved
docs/run-conformance-tests.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/document-conformance-tests-run branch from 744342c to e32bd90 Compare April 1, 2020 13:56
@surajssd surajssd requested a review from invidian April 1, 2020 13:58
@surajssd surajssd force-pushed the surajssd/document-conformance-tests-run branch from e32bd90 to 90c0897 Compare April 1, 2020 14:14
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @surajssd, It looks good to me. I pointed one more clarification, but otherwise it looks fine.

Perhaps @johananl or @iaguis could check the wording too before merging.

docs/run-conformance-tests.md Outdated Show resolved Hide resolved
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

docs/run-conformance-tests.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/document-conformance-tests-run branch 3 times, most recently from 3a129d3 to 254a2c3 Compare April 2, 2020 09:24
@surajssd surajssd requested review from invidian and iaguis April 2, 2020 09:25
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, sorry 😅

docs/run-conformance-tests.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/document-conformance-tests-run branch 2 times, most recently from c7b7594 to 2fb6c7d Compare April 2, 2020 11:52
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This boolean type variable is used to expose node ports in the security
group of AWS installation. By default this variable is set to `false`.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/document-conformance-tests-run branch 3 times, most recently from fa7c6b9 to beba4a2 Compare April 2, 2020 13:15
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/document-conformance-tests-run branch from beba4a2 to a17e3ec Compare April 2, 2020 13:51
@surajssd surajssd requested a review from iaguis April 2, 2020 14:13
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@surajssd surajssd merged commit 4589317 into master Apr 2, 2020
@surajssd surajssd deleted the surajssd/document-conformance-tests-run branch April 2, 2020 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define and document process for running conformance tests
3 participants