This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
quickstart-docs: Add ssh-agent instructions #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
surajssd/add-ssh-agent-doc
branch
3 times, most recently
from
e31254d
to
e246414
Compare
invidian
suggested changes
Apr 23, 2020
surajssd
force-pushed
the
surajssd/add-ssh-agent-doc
branch
from
e246414
to
d9aa0fb
Compare
johananl
reviewed
Apr 23, 2020
docs/quickstarts/aws.md
Outdated
| @@ -121,6 +121,13 @@ guide](../configuration-reference/platforms/aws.md). | |||
|
|
|||
| ### Step 5: Create Lokomotive cluster | |||
|
|
|||
| Lokoctl uses Terraform behind the scene and it needs SSH access to controller nodes. For SSH to work add at least one SSH private key corresponding to the public keys specified earlier, to your `ssh-agent`. | |||
There was a problem hiding this comment.
Suggested change
| Lokoctl uses Terraform behind the scene and it needs SSH access to controller nodes. For SSH to work add at least one SSH private key corresponding to the public keys specified earlier, to your `ssh-agent`. | |
| Add a private key corresponding to one of the public keys specified in `ssh_pubkeys` to your ssh-agent: |
- IMO it's irrelevant to mention that lokoctl uses Terraform here. All the user needs to know is that they should add an SSH key to ssh-agent.
- "Lokoctl" should be "lokoctl".
- "behind the scene" should be "behind the scenes".
- I like using a colon at the end of an instruction that is followed by a code snippet. We are currently inconsistent there but if we should settle on something, I suggest it be a colon rather than a period.
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-ssh-agent-doc
branch
from
d9aa0fb
to
fa0fe1b
Compare
invidian
approved these changes
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #248