This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Add a knob to disable self hosted kubelet #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
suggested changes
May 13, 2020
assets/lokomotive-kubernetes/bootkube/resources/charts/kubelet.yaml
Outdated
Show resolved
Hide resolved
|
I think we also need to document, that disabling self-hosted kubelet makes it difficult to upgrade, as kubelet needs to be upgraded manually for every node. |
surajssd
force-pushed
the
surajssd/add-knob-to-disable-self-hosted-kubelet
branch
2 times, most recently
from
4505b70
to
2be6c79
Compare
surajssd
force-pushed
the
surajssd/add-knob-to-disable-self-hosted-kubelet
branch
13 times, most recently
from
73ebf14
to
7ce11c7
Compare
invidian
suggested changes
May 15, 2020
assets/lokomotive-kubernetes/bare-metal/flatcar-linux/kubernetes/bootkube.tf
Outdated
Show resolved
Hide resolved
This flag adds a variable `disable_self_hosted_kubelet` to bootkube so that installation of self hosted kubelet can be disabled. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This commit adds a boolean variable to controller config called `disable_self_hosted_kubelet`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This commit adds a boolean variable to controller config called `disable_self_hosted_kubelet`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This commit adds a boolean variable to controller config called `disable_self_hosted_kubelet`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-knob-to-disable-self-hosted-kubelet
branch
from
7ce11c7
to
101934d
Compare
invidian
approved these changes
May 15, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.