This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
pod-checkpointer: Update to pod-checkpointer image that fixes #432 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
from
b6a1130
to
ce9041a
Compare
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
from
ce9041a
to
29e2a28
Compare
ipochi
changed the title
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
from
29e2a28
to
e622e63
Compare
invidian
previously approved these changes
May 28, 2020
iaguis
previously approved these changes
May 28, 2020
There was a problem hiding this comment.
Added a small comment to https://github.com/kinvolk/bootkube/pull/2 but otherwise this LGTM.
|
You might wanna mention in the commit message the Kubelet running as a DaemonSet listens on the Host IP of the node and that's why you need the pod checkpointer to access the Host IP. |
surajssd
reviewed
May 29, 2020
...ts/lokomotive-kubernetes/bootkube/resources/charts/pod-checkpointer/templates/daemonset.yaml
Show resolved
Hide resolved
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
2 times, most recently
from
7ea91f3
to
c94ed88
Compare
done. |
iaguis
reviewed
May 29, 2020
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
from
c94ed88
to
e650fcc
Compare
invidian
previously approved these changes
May 29, 2020
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
2 times, most recently
from
6015488
to
3dbfbfb
Compare
|
Baremetal pipline has been a PITA, @ipochi can you rebase and trigger CI again? |
- Fixes #432. - pod-checkpointer pod logs errors as it cannot talk to the kubelet api as mentioned in the issue. This is becuase the pod-checkpointer queries the localhost at 10250 and 10255 ports to talk to the kubelet API. Since in Lokomotive, we run the kubelet as a pod, this causes `connection refused` errors as nothing is listening at localhost. To rectify the above problem, the solution requires chanves in two places: 1. Provide a way to access the pod's `status.hostIP` as an environment variable named `HOST_IP` to use instead of localhost. This is done by modifying the daemonset configuration of kubelet. 2. Change the pod-checkpointer code to use the `HOST_IP` from above. This is done in the PR: https://github.com/kinvolk/bootkube/pull/2 - Next we update the image tag to use the new pod-checkpointer image. The tag includes the commit id which made this change. - Lastly we update the generated assets. Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/lokomotive-issue-432
branch
from
3dbfbfb
to
8714e85
Compare
invidian
approved these changes
Jun 2, 2020
iaguis
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PodCheckpointer cannot talk to kubelet and logs errors #432.
pod-checkpointer pod logs errors as it cannot talk to the kubelet api
as mentioned in the issue.
This is becuase the pod-checkpointer queries the localhost at 10250 and
10255 ports to talk to the kubelet API.
Since in Lokomotive, we run the kubelet as a pod, this causes
connection refusederrors as nothing is listening at localhost.To rectify the above problem, the solution requires chanves in two
places:
Provide a way to access the pod's
status.hostIPas an environmentvariable named
HOST_IPto use instead of localhost. This is done bymodifying the daemonset configuration of kubelet.
Change the pod-checkpointer code to use the
HOST_IPfrom above.This is done in the PR: https://github.com/kinvolk/bootkube/pull/2
Next we update the image tag to use the new pod-checkpointer image.
The tag includes the commit id which made this change.
Lastly we update the generated assets.
Signed-off-by: Imran Pochi imran@kinvolk.io