This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
New internal package for helper functions #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
suggested changes
Jun 9, 2020
ipochi
force-pushed
the
imran/create-internal-package-for-helper-functions
branch
from
96e7bc4
to
2fbb1a2
Compare
ipochi
force-pushed
the
imran/create-internal-package-for-helper-functions
branch
from
2fbb1a2
to
ad58fa2
Compare
invidian
previously approved these changes
Jun 9, 2020
Adding a new internal package for utility and helper functions that need not be exposed outside. Currently there are lot of util packages in the codebase. Having an internal package helps in consolidating all such helper functions in this internal package rather than having separate util package/files in different places in the codebase. The first function that is to be added is RenderTemplate which renders provided go template. Adds unit tests for the same. Signed-off-by: Imran Pochi <imran@kinvolk.io>
Since RenderTemplate function is now part of the `internal` package, this caused duplication. Hence the file `template.go` is removed from the codebase. Also we update the references to `util.RenderTemplate` to now refer to the correct package and function. Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/create-internal-package-for-helper-functions
branch
from
ad58fa2
to
f0f21f3
Compare
Commit 1: introduces new package and its tests |
invidian
approved these changes
Jun 9, 2020
surajssd
reviewed
Jun 11, 2020
|
|
||
| internaltemplate "github.com/kinvolk/lokomotive/internal/template" |
There was a problem hiding this comment.
Q: Why is it imported as internaltemplate? Name conflicts?
There was a problem hiding this comment.
Can we import it as internaltemplate everywhere else? So it becomes easier to read code?
There was a problem hiding this comment.
yes Suraj, name conflicts with Go library template package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
internalpackage that is not exposed to the outside world. The intention is to begin consolidating functions in variousutilpackages scattered in the codebase.The first function that is to be added is RenderTemplate which renders the provided go template.