This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Remove provider aliases from go templates #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been tested successfully with upgrades? I'd welcome a bit more context in the commit message. |
|
From my testing, this required running |
From the official terraform docs, while the `provider` blocks can appear in any module, it is recommended that they be placed only in root module of a configuration, since this approach allows users to configure providers just once and reuse them across all descendent modules terraform.io/docs/configuration/modules.html#providers-within-modules for more information Fixes #539 Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/provider-alias-fix
branch
from
390fdd9
to
ffe986f
Compare
|
@iaguis @invidian I tested for up-gradation and it worked fine. First I deployed cluster on packet using Initial
Final
|
knrt10
requested review from
invidian and
iaguis
and removed request for
invidian
|
I'll test again now. |
invidian
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: knrt10 kautilya@kinvolk.io