Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Improve Backend Documentation #670

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Improve Backend Documentation #670

merged 2 commits into from
Jul 2, 2020

Conversation

BrainBlasted
Copy link
Contributor

  • Provides instructions on how to set up the S3 backend
  • Adds reference to backend configuration to quickstarts

invidian
invidian suggested changes Jun 25, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits from my side. Perhaps @johananl or @iaguis could verify the wording.

docs/quickstarts/aks.md Outdated Show resolved Hide resolved
docs/configuration-reference/backend/s3.md Outdated Show resolved Hide resolved
docs/configuration-reference/backend/s3.md Outdated Show resolved Hide resolved
iaguis
iaguis suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language comments.

docs/configuration-reference/backend/s3.md Outdated Show resolved Hide resolved
docs/configuration-reference/backend/s3.md Outdated Show resolved Hide resolved
docs/quickstarts/aks.md Outdated Show resolved Hide resolved
docs/quickstarts/aks.md Outdated Show resolved Hide resolved
docs/quickstarts/aws.md Outdated Show resolved Hide resolved
docs/quickstarts/baremetal.md Outdated Show resolved Hide resolved
docs/quickstarts/packet.md Outdated Show resolved Hide resolved
@BrainBlasted BrainBlasted requested a review from iaguis July 1, 2020 21:19
iaguis
iaguis approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iaguis iaguis merged commit fc47cfb into master Jul 2, 2020
@iaguis iaguis deleted the cdavis/backend-documentation branch July 2, 2020 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iaguis iaguis iaguis approved these changes

@invidian invidian invidian approved these changes

@ipochi ipochi Awaiting requested review from ipochi

@johananl johananl Awaiting requested review from johananl

@surajssd surajssd Awaiting requested review from surajssd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrainBlasted @iaguis @invidian