Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Update cluster-autoscaler to v2 version 1.0.2 #859

Merged
merged 3 commits into from
Aug 27, 2020

Conversation

knrt10
Copy link
Member

@knrt10 knrt10 commented Aug 26, 2020

Release info:
kubernetes/autoscaler/releases/tag/cluster-autoscaler-chart-1.0.2

Fixes #858

Signed-off-by: knrt10 kautilya@kinvolk.io

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knrt10 did you test that updated component actually works on Packet? I see a lot of removal in the chart related to Packet, has this been added someplace else? If not, perhaps we should create an issue and submit our changes upstream.

@knrt10
Copy link
Member Author

knrt10 commented Aug 26, 2020

Didn't test it, let me do that

@knrt10 knrt10 force-pushed the knrt10/update-cluster-autoscaler branch 3 times, most recently from fe00dcf to 660367a Compare August 26, 2020 10:59
@knrt10 knrt10 requested a review from invidian August 26, 2020 10:59
@knrt10 knrt10 force-pushed the knrt10/update-cluster-autoscaler branch 3 times, most recently from 835dfeb to dfcd74d Compare August 26, 2020 11:06
invidian
invidian previously approved these changes Aug 27, 2020
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We've tested the autoscaler together with @knrt10 and it deploys and runs correctly, but it's functionality is still broken 😞

@knrt10
Copy link
Member Author

knrt10 commented Aug 27, 2020

Opened an issue upstrem and awaiting fix from Packet regarding 503 internal server error.

Release info:
kubernetes/autoscaler/releases/tag/cluster-autoscaler-chart-1.0.2

Fixes #858

Signed-off-by: knrt10 <kautilya@kinvolk.io>
Signed-off-by: knrt10 <kautilya@kinvolk.io>
@invidian
Copy link
Member

@knrt10 the override needs to be removed :)

@knrt10
Copy link
Member Author

knrt10 commented Aug 27, 2020

Aaah, my bad, doing it

cluster-autoscaler chart now deploys v.18.1 by default.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@knrt10 knrt10 merged commit a57d1aa into master Aug 27, 2020
@knrt10 knrt10 deleted the knrt10/update-cluster-autoscaler branch August 27, 2020 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cluster-autoscaler chart to v2 version 1.0.2
3 participants