This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Replace remaining uses of github.com/pkg/errors with fmt #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
invidian/finish-errors-wrapping
branch
from
5a9e78e
to
35f0d67
Compare
knrt10
reviewed
Aug 28, 2020
knrt10
reviewed
Aug 28, 2020
knrt10
reviewed
Aug 28, 2020
knrt10
reviewed
Aug 28, 2020
knrt10
reviewed
Aug 28, 2020
Even though all of them should actually be removed, this commit finishes the migration to 'fmt.Errorf' for the sake of consistency and effectively drops the direct dependency on 'github.com/pkg/errors'. Closes #59 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/finish-errors-wrapping
branch
from
35f0d67
to
b8e814d
Compare
|
I'll merge to avoid conflicts appearing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though all of them should actually be removed, this commit finishes
the migration to 'fmt.Errorf' for the sake of consistency and
effectively drops the direct dependency on 'github.com/pkg/errors'.
Closes #59
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io