Add document for admission webhook #943

knrt10 · 2020-09-10T14:15:38Z

Closes: #913

Signed-off-by: knrt10 kautilya@kinvolk.io

invidian

Some thoughts.

docs/concepts/admission-webhook.md

knrt10 · 2020-09-11T11:44:10Z

@invidian does this look ok?

invidian

@knrt10 I think we still need to iterate a bit over this document to make the content more concise and specific. Please see my comments.

docs/concepts/admission-webhook.md

invidian

Some nits. In general it looks better now, but I think still @iaguis or @johananl should have a look at it.

docs/concepts/admission-webhook.md

johananl

Thanks @knrt10. The info looks good to me, however there are multiple language problems which I think should be fixed. I'll do my best to add a proper docs style guide to the repo soon so that things will seem less "arbitrary".

docs/concepts/admission-webhook.md

re requesting review

invidian

Looks okay to me.

johananl

Looks a lot better to me @knrt10.

I still have a few more nitpicks though :-)

docs/concepts/admission-webhook.md

johananl

Thanks for fixing. Looks better.

I've left some comments.

docs/concepts/admission-webhook.md

knrt10 · 2020-09-22T11:25:05Z

@johananl updated

Closes: #913 Signed-off-by: knrt10 <kautilya@kinvolk.io>

johananl

LGTM

knrt10 · 2020-09-22T11:49:42Z

Thanks @johananl @invidian for through review

knrt10 requested review from johananl and invidian September 10, 2020 14:15

invidian suggested changes Sep 10, 2020

View reviewed changes

knrt10 force-pushed the knrt10/document-webhook-controller branch from a79b506 to 614d779 Compare September 11, 2020 11:43

knrt10 requested a review from invidian September 11, 2020 11:43

invidian suggested changes Sep 14, 2020

View reviewed changes

knrt10 force-pushed the knrt10/document-webhook-controller branch from 614d779 to 0178731 Compare September 16, 2020 10:32

knrt10 requested a review from invidian September 16, 2020 10:33

invidian previously requested changes Sep 16, 2020

View reviewed changes

invidian requested a review from iaguis September 16, 2020 11:13

knrt10 force-pushed the knrt10/document-webhook-controller branch from 0178731 to bd9bbe0 Compare September 16, 2020 11:27

invidian reviewed Sep 16, 2020

View reviewed changes

docs/concepts/admission-webhook.md Outdated Show resolved Hide resolved

knrt10 force-pushed the knrt10/document-webhook-controller branch from bd9bbe0 to 9a763fc Compare September 16, 2020 11:33

knrt10 requested a review from invidian September 16, 2020 11:33

johananl previously requested changes Sep 17, 2020

View reviewed changes

knrt10 force-pushed the knrt10/document-webhook-controller branch from 9a763fc to 5c7fa58 Compare September 21, 2020 10:50

knrt10 requested a review from johananl September 21, 2020 10:50

knrt10 force-pushed the knrt10/document-webhook-controller branch from 5c7fa58 to b6e612a Compare September 21, 2020 10:52

invidian previously approved these changes Sep 21, 2020

View reviewed changes

johananl reviewed Sep 21, 2020

View reviewed changes

knrt10 dismissed invidian’s stale review via 11e7541 September 22, 2020 06:41

knrt10 force-pushed the knrt10/document-webhook-controller branch from b6e612a to 11e7541 Compare September 22, 2020 06:41

knrt10 requested review from johananl and invidian September 22, 2020 06:41

invidian previously approved these changes Sep 22, 2020

View reviewed changes

johananl reviewed Sep 22, 2020

View reviewed changes

knrt10 dismissed invidian’s stale review via d843603 September 22, 2020 11:25

knrt10 force-pushed the knrt10/document-webhook-controller branch from 11e7541 to d843603 Compare September 22, 2020 11:25

knrt10 requested review from johananl and invidian September 22, 2020 11:25

Add document for admission webhook

621711b

Closes: #913 Signed-off-by: knrt10 <kautilya@kinvolk.io>

knrt10 force-pushed the knrt10/document-webhook-controller branch from d843603 to 621711b Compare September 22, 2020 11:26

johananl approved these changes Sep 22, 2020

View reviewed changes

invidian approved these changes Sep 22, 2020

View reviewed changes

knrt10 merged commit 8093a06 into master Sep 22, 2020

knrt10 deleted the knrt10/document-webhook-controller branch September 22, 2020 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add document for admission webhook #943

Add document for admission webhook #943

knrt10 commented Sep 10, 2020

invidian left a comment

knrt10 commented Sep 11, 2020

invidian left a comment

invidian left a comment

johananl left a comment

invidian left a comment

johananl left a comment

johananl left a comment

knrt10 commented Sep 22, 2020

johananl left a comment

knrt10 commented Sep 22, 2020

Add document for admission webhook #943

Add document for admission webhook #943

Conversation

knrt10 commented Sep 10, 2020

invidian left a comment

Choose a reason for hiding this comment

knrt10 commented Sep 11, 2020

invidian left a comment

Choose a reason for hiding this comment

invidian left a comment

Choose a reason for hiding this comment

johananl left a comment

Choose a reason for hiding this comment

invidian left a comment

Choose a reason for hiding this comment

johananl left a comment

Choose a reason for hiding this comment

johananl left a comment

Choose a reason for hiding this comment

knrt10 commented Sep 22, 2020

johananl left a comment

Choose a reason for hiding this comment

knrt10 commented Sep 22, 2020