This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Fix output of convertNodeSelector in rook
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
reviewed
Sep 11, 2020
invidian
suggested changes
Sep 11, 2020
Earlier it was looping through map so output was not consistent. Closes: #942 Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/node-selector-order-fix
branch
from
6d3497b
to
f4dd144
Compare
invidian
suggested changes
Sep 11, 2020
Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/node-selector-order-fix
branch
from
f4dd144
to
d4a5688
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier it was looping through map so output was not consistent.
Closes: #942
Signed-off-by: knrt10 kautilya@kinvolk.io