This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Remove pkg/util package #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2020
knrt10
reviewed
Sep 15, 2020
|
I have noticed that 6minutes looks like a good time for the nodes to join. So we should timeout after 6minutes. See #940 (comment) for more details. |
invidian
force-pushed
the
invidian/more-cleanup
branch
from
b168164
to
5cf18ec
Compare
Right, let me check it. What about some nice number like 5 minutes for API and 10 minutes for nodes? |
knrt10
previously approved these changes
Sep 15, 2020
surajssd
previously approved these changes
Sep 15, 2020
|
AKS didn't start on this :-\ |
|
That's weird because no other process is running. |
As this is the only place which use those functions. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
As it is not used anywhere. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
As they provide the same functionality, but PollImmediate has more obvious interface (as you don't mix duration with number of retries). Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This code is no loger used so can be removed. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
3 minutes seems like an arbitrary time to wait for cluster to become ready, so let's make it at least round to 5 minutes. As currently we have issues, that nodes do not become ready within 3 minutes timeframe, let's give them max 10 minutes to converge, which should be sufficient in most cases, as sometimes it may take up to 5 minutes for node to become ready. Closes #940. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/more-cleanup
branch
from
9a81e25
to
5ca727b
Compare
|
Rebased and push again to poke CI. |
surajssd
approved these changes
Sep 15, 2020
knrt10
approved these changes
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes commits from #951
Part of #290