Add TODO

kinvolk · Oct 23, 2019 · 7860f55 · 7860f55
1 parent fc6f34e
commit 7860f55
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py b/ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py
@@ -164,6 +164,11 @@ def active(self):
         span_context = SpanContextShim(span.get_context())
         wrapped_span = SpanShim(self._tracer, span_context, span)
         return ScopeShim(self, span=wrapped_span)
+        # TODO: The returned `ScopeShim` instance here always ends the
+        # corresponding span, regardless of the `finish_on_close` value used
+        # when activating the span. This is because here we return a *new*
+        # `ScopeShim` rather than returning a saved instance of `ScopeShim`.
+        # https://github.com/open-telemetry/opentelemetry-python/pull/211/files#r335398792
 
     @property
     def tracer(self):