Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement application/x-www-form-urlencoded serialization #26

Merged
merged 27 commits into from
Jul 17, 2024
Merged

Implement application/x-www-form-urlencoded serialization #26

merged 27 commits into from
Jul 17, 2024

Conversation

ricardoboss
Copy link
Member

@ricardoboss ricardoboss commented Apr 9, 2024 •
edited
Loading

Fixes #25

@ricardoboss ricardoboss force-pushed the issues/25-form-serialization branch from fa74186 to 5067463 Compare June 26, 2024 07:39
@ricardoboss ricardoboss marked this pull request as ready for review June 26, 2024 16:02
baywet
baywet reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great as far as I understand dart! I left a few questions for you

packages/kiota_abstractions/lib/src/extensions/string_extensions.dart Outdated Show resolved Hide resolved
packages/kiota_abstractions/lib/src/enum_registry.dart Outdated Show resolved Hide resolved
@ricardoboss
Copy link
Member Author

ricardoboss commented Jun 26, 2024 •
edited
Loading

@baywet I may need to add a major rewrite to make all write* functions in the serializers to be async. This is because the Parsables serialize method may return a Future (aka .NET Task).

Do we want to move that change into a different PR?

Edit: #29
Edit again: this change was reverted as we decided to make everything sync for now.

@ricardoboss ricardoboss self-assigned this Jun 26, 2024
@ricardoboss ricardoboss added the enhancement New feature or request label Jun 26, 2024
@ricardoboss ricardoboss force-pushed the issues/25-form-serialization branch from b4e6db7 to 9601c1f Compare June 27, 2024 16:07
@ricardoboss ricardoboss requested a review from baywet June 28, 2024 13:39
ricardoboss added 17 commits July 14, 2024 22:40
@ricardoboss
Started implementing form serialization; added EnumRegistry
f5e1edc
@ricardoboss
Use DurationExtension to parse durations
23d237c
@ricardoboss
Added serialization form to Makefile
769c4d0
@ricardoboss
Finished implementing FormParseNode
2ac7650
@ricardoboss
Added FormParseNodeFactory
98a5948
@ricardoboss
Also forward the hooks to child nodes
5a49ce6
@ricardoboss
Added form serialization package to workflow
7535dfb
@ricardoboss
Added more types to the serialization writer
869d00d
@ricardoboss
Added partial implementation of FormSerializationWriter
0954e8e
@ricardoboss
Don't write empty keys or values
2bb10bf
@ricardoboss
Implement the rest of the form serialization writer
83f7f79
@ricardoboss
Implemented FormSerializationWriterFactory
2d9a2a4
@ricardoboss
Added tests, fixed bugs, added run configurations, updated makefile
6a97d64
@ricardoboss
Also generate code for kiota_serialization_form tests
651a21c
@ricardoboss
Fixed analysis issues
b1820d1
@ricardoboss
Don't modify enum cases during serialization
aa66db8
@ricardoboss
Check in run config for serialization form tests
8850f40
@ricardoboss ricardoboss force-pushed the issues/25-form-serialization branch from 4571362 to 56d27f2 Compare July 14, 2024 20:42
baywet
baywet approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ricardoboss ricardoboss merged commit d00f0fd into main Jul 17, 2024
4 checks passed
@baywet baywet deleted the issues/25-form-serialization branch July 17, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

@ricardoboss ricardoboss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kiota_serialization_form: Form serialization
3 participants
@ricardoboss @andrueastman @baywet