fix: expect only persistant commands to persist (do not fail assertion because of non-persistant ones) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
4 times, most recently
from
9ba7444
to
d860fbc
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
d860fbc
to
677a26a
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
677a26a
to
5c6f9c7
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
5c6f9c7
to
e84378a
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
e84378a
to
4597b24
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
4597b24
to
94efe46
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
94efe46
to
a6c8d78
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
a6c8d78
to
9e89866
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
9e89866
to
fc7c8c2
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
fc7c8c2
to
47fe88c
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
47fe88c
to
6339eb8
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
6339eb8
to
5605b6d
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
5605b6d
to
22ac353
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
22ac353
to
97c3444
Compare
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
2 times, most recently
from
1a272f3
to
84e176a
Compare
…n because of non-persistant ones) root issue was noticed when doing a simple git-stacked-rebase and adding a `break` inside the git-rebase-todo file -- `--apply` would always fail because there'd be 1 less command than expected. Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
…concurrent-safe Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
kiprasmel
force-pushed
the
fix/expect-only-persistant-commands-to-persist
branch
from
84e176a
to
42f69ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root issue was noticed when doing a simple git-stacked-rebase and adding
a
breakinside the git-rebase-todo file ----applywould always failbecause there'd be 1 less command than expected.