More readability

kirbydesign · Nov 19, 2024 · f993012 · f993012
1 parent ecd18b2
commit f993012
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/apps/cookbook/src/app/showcase/alert-showcase/alert-showcase.component.html b/apps/cookbook/src/app/showcase/alert-showcase/alert-showcase.component.html
@@ -52,7 +52,7 @@ <h2>Accessibility</h2>
     back to where it was before showing the alert.
   </p>
 
-  <h3>Meaningful titles</h3>
+  <h3>Labeling</h3>
   <p>
     The alert title is automatically used as a label to add context for assistive technologies. For
     example, screen readers use the label to announce when the modal dialog appears and to give

diff --git a/apps/cookbook/src/app/showcase/modal-showcase/modal-showcase.component.html b/apps/cookbook/src/app/showcase/modal-showcase/modal-showcase.component.html
@@ -679,15 +679,15 @@ <h2 #accessibility>Accessibility</h2>
   dismisses the modal.
 </p>
 
-<h3>Labeling modals</h3>
+<h3>Labeling</h3>
 <p>
   The provided
   <code>kirby-page-title</code>
   is automatically used as a label to add context for assistive technologies. For example, screen
   readers use the label to announce when the modal dialog appears and to give proper context when
   interacting with the content within.
 </p>
-<p>This emphasizes the importance of providing a meaningful title for all alerts.</p>
+<p>This emphasizes the importance of providing a meaningful title for all modals.</p>
 
 <h4>Compact Modals</h4>
 <p>

diff --git a/libs/designsystem/helpers/src/content-mutation-observer.spec.ts b/libs/designsystem/helpers/src/content-mutation-observer.spec.ts
@@ -25,7 +25,7 @@ class ContentObserverHostComponent implements OnDestroy {
   }
 }
 
-describe('Content Mutation Observer', () => {
+describe('observeContent', () => {
   let spectator: Spectator<ContentObserverHostComponent>;
 
   const createComponent = createComponentFactory({

diff --git a/libs/designsystem/helpers/src/content-mutation-observer.ts b/libs/designsystem/helpers/src/content-mutation-observer.ts
@@ -31,7 +31,7 @@ function shouldIgnoreMutationRecord(record: MutationRecord) {
 export function observeContent(
   observedElement: HTMLElement,
   contentChangedCallback: () => void,
-  disconnect$: Observable<void>
+  unobserve$?: Observable<void>
 ): MutationObserver {
   const mutationObserver = new MutationObserver((mutations) => {
     const filteredMutations = mutations.filter((mutation) => !shouldIgnoreMutationRecord(mutation));
@@ -46,7 +46,7 @@ export function observeContent(
     subtree: true,
   });
 
-  disconnect$.subscribe(() => {
+  unobserve$?.subscribe(() => {
     mutationObserver.disconnect();
   });
 

diff --git a/libs/designsystem/helpers/src/element-ancestor-utils.ts b/libs/designsystem/helpers/src/element-ancestor-utils.ts
@@ -28,7 +28,7 @@ export const elementHasAncestor = (
 };
 
 /*
- * Utility function to get the closest ancestor modal and
+ * Utility function to find the closest ancestor modal and
  * get the element with a dialog role from within its shadow root.
  */
 export function getModalDialogAncestor(currentElement: HTMLElement): HTMLElement | undefined {