Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove Highchart Charts #1578

Closed
4 of 5 tasks
Tracked by #2061
MadsBuchmann opened this issue Jun 3, 2021 · 6 comments · Fixed by #2334
Closed
4 of 5 tasks
Tracked by #2061

[Enhancement] Remove Highchart Charts #1578

MadsBuchmann opened this issue Jun 3, 2021 · 6 comments · Fixed by #2334
Assignees

Comments

@MadsBuchmann
Copy link
Contributor

MadsBuchmann commented Jun 3, 2021

Please add a short description of your enhancement request
Once #1652 has been carried out and we know when to finally remove the old chart components - all of the old chart components should be removed.

Todo:

  • Remove the kirby-chart-deprecated component
  • Remove the kirby-stock-chart-deprecated component
  • Remove associated cookbook pages for both
  • Remove any & all dependencies to highcharts in package.json files!
  • Ship it & celebrate with colleagues in close proximity! 🚣💨🕺💃

Additional context
This is part of an epic - please have a look at it: #1413
Also #1652 should be carried out before this task.

@MadsBuchmann MadsBuchmann added enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT UX refined labels Jun 3, 2021
@MadsBuchmann MadsBuchmann self-assigned this Jun 3, 2021
@MadsBuchmann MadsBuchmann removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jun 3, 2021
@MadsBuchmann MadsBuchmann changed the title [Enhancement] Replace Highchart Charts with New Implemenetations of Column- & Bar chart [Enhancement] Replace Highchart Charts with ChartJS Implemenetations Jun 3, 2021
@MadsBuchmann MadsBuchmann changed the title [Enhancement] Replace Highchart Charts with ChartJS Implemenetations [Enhancement] Remove Highchart Charts & release ChartJS Implemenetations Jun 3, 2021
@MadsBuchmann
Copy link
Contributor Author

Also remember to remove the Stock Chart component: https://cookbook.kirby.design/home/showcase/stock-chart

It is not in use by any consumer projects and can safely be removed ☄️

@MadsBuchmann MadsBuchmann removed NOT UX refined NOT Tech refined Needs Tech kickoff - solution outlined and agreed labels Jul 1, 2021
@MadsBuchmann MadsBuchmann changed the title [Enhancement] Remove Highchart Charts & release ChartJS Implemenetations [Enhancement] Remove Highchart Charts Jul 21, 2021
@MadsBuchmann MadsBuchmann added this to the Masterplanning 9 milestone Sep 8, 2021
@MadsBuchmann MadsBuchmann removed their assignment Sep 21, 2021
@alxzak alxzak removed this from the Masterplanning 9 milestone Oct 25, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Automatically applied when there is no activity on an issue or PR label Jan 3, 2022
@MadsBuchmann
Copy link
Contributor Author

MadsBuchmann commented Jan 3, 2022

@alxzak All blockers for this has been removed. Perhaps a candidate for the next major version?

@stale stale bot removed the stale Automatically applied when there is no activity on an issue or PR label Jan 3, 2022
@alxzak alxzak added this to the M11 ( 27/1 - 6/4 ) milestone Feb 21, 2022
@alxzak alxzak added this to Kirby Feb 21, 2022
@MadsBuchmann MadsBuchmann self-assigned this Feb 24, 2022
@MadsBuchmann MadsBuchmann moved this to 🚀 In Progress in Kirby Feb 25, 2022
@MadsBuchmann MadsBuchmann moved this from 🚀 In Progress to 🔎 Review pending in Kirby Feb 25, 2022
@MadsBuchmann MadsBuchmann moved this from 🔎 Review pending to 🟢 Ready for next release in Kirby Feb 28, 2022
@MadsBuchmann
Copy link
Contributor Author

MadsBuchmann commented Mar 24, 2022

Scheduled for v7; a branch exists where highcharts and the components have been removed https://github.com/kirbydesign/designsystem/tree/enhancement/1578-remove-highchart-charts

Remember to rebase it once it's actually going to be used :-)

@MadsBuchmann MadsBuchmann moved this from 🟢 Ready for next release to ✅ Done in Kirby Apr 8, 2022
@jkaltoft jkaltoft reopened this Apr 22, 2022
@jkaltoft
Copy link
Collaborator

We need a PR for https://github.com/kirbydesign/designsystem/tree/enhancement/1578-remove-highchart-charts.
Consider creating a new base branch for release v7

@RasmusKjeldgaard RasmusKjeldgaard moved this from ✅ Done to 📙 Backlog in Kirby May 30, 2022
@MadsBuchmann MadsBuchmann moved this from 📙 Backlog to 🔎 Review pending in Kirby Jun 14, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review pending to 👀 Review in progess in Kirby Jun 15, 2022
@jkaltoft jkaltoft linked a pull request Jun 16, 2022 that will close this issue
7 tasks
@MadsBuchmann
Copy link
Contributor Author

#2334 has been merged

Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants