Remove highcharts dependency #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadsBuchmann
changed the title
github-actions
bot
temporarily deployed
to
pr-1578-remove-highchart-charts-2
github-actions
bot
temporarily deployed
to
pr-1578-remove-highchart-charts-2
| { | ||
| path: 'chart-deprecated', | ||
| component: ChartDeprecatedExampleComponent, | ||
| }, | ||
| { | ||
| path: 'chart', | ||
| component: ChartExampleComponent, | ||
| }, | ||
| { | ||
| path: 'stock-chart-deprecated', |
There was a problem hiding this comment.
Should this line be removed too?
There was a problem hiding this comment.
It indeed should! I've removed it.
RasmusKjeldgaard
requested changes
Jun 14, 2022
RasmusKjeldgaard
approved these changes
Jun 15, 2022
5 tasks
jkaltoft
approved these changes
Jun 16, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #1578
What is the new behavior?
The highcharts dependency has been removed. All components along with specs, mocks, etc. has been removed. This means the two elements:
kirby-stock-chart-deprecated&kirby-chart-deprecatedcan no longer be used.Does this PR introduce a breaking change?
Migration guide
The new
kirby-stockcomponent should be used instead. It has types equivalent to the ones used in highcharts.Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
developby Team Kirby.