Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollable ion-segment (segmented-control) [Enhancement] #2235

Closed
2 of 11 tasks
RasmusTraeholt opened this issue May 9, 2022 · 0 comments · Fixed by #2237
Closed
2 of 11 tasks

scrollable ion-segment (segmented-control) [Enhancement] #2235

RasmusTraeholt opened this issue May 9, 2022 · 0 comments · Fixed by #2237
Labels
component:Segmented Control enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed 🟢 Ready for release

Comments

@RasmusTraeholt
Copy link
Collaborator

RasmusTraeholt commented May 9, 2022

Describe the enhancement

We would like to be able to disable segment select on swipe when using the segmented-control component in scrollable context.

Describe the solution you'd like

A simple way to disable above mentioned (preferably from an attribute on the segmented-control component)

Have you considered any alternatives?

No

Are there any additional context?

No


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the stable branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusTraeholt RasmusTraeholt added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels May 9, 2022
@jkaltoft jkaltoft added this to Kirby May 24, 2022
@jkaltoft jkaltoft moved this to ✅ Done in Kirby May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Segmented Control enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed 🟢 Ready for release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants