Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segmented-control - disable change on swipe attribute #2237

Merged

Conversation

RasmusTraeholt
Copy link
Collaborator

Which issue does this PR close?

This PR closes #2235

What is the new behavior?

Introduced a new input attribute to the segmented-control component (disableChangeOnSwipe), which sets the scrollable attribute on the ion-segment

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to stable via automerge.

@github-actions github-actions bot temporarily deployed to pr-disable-change-on-swipe May 9, 2022 11:12 Inactive
@RasmusKjeldgaard RasmusKjeldgaard merged commit 58973e6 into main May 23, 2022
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/segmented-control/disable-change-on-swipe branch May 23, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrollable ion-segment (segmented-control) [Enhancement]
2 participants