Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown keyboard navigation selects an option #2342

Closed
Tracked by #2329
RasmusKjeldgaard opened this issue Jun 15, 2022 · 2 comments · Fixed by #2424
Closed
Tracked by #2329

Dropdown keyboard navigation selects an option #2342

RasmusKjeldgaard opened this issue Jun 15, 2022 · 2 comments · Fixed by #2424
Assignees

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Jun 15, 2022

It should just hover it and space/enter should select it.

@RasmusKjeldgaard RasmusKjeldgaard changed the title Keyboard navigation accidentally selects an option. It should just hover it and space/enter should select it. Dorpdwon keyboard navigation selects an option. Jun 15, 2022
@RasmusKjeldgaard RasmusKjeldgaard changed the title Dorpdwon keyboard navigation selects an option. Dropdown keyboard navigation selects an option Jun 15, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this to 📙 Backlog in Kirby Jun 15, 2022
@alxzak alxzak added this to the Interaction States milestone Jun 16, 2022
@jkaltoft jkaltoft moved this from 📙 Backlog to 🚀 In Progress in Kirby Aug 16, 2022
@jkaltoft jkaltoft self-assigned this Aug 16, 2022
@jkaltoft
Copy link
Collaborator

jkaltoft commented Aug 22, 2022

After implementing a working solution, the following issues have to be solved

  • Fix bug: Don't select previously focused (non-selected) Item when opening again
    • Open Dropdown using ENTER/SPACE
    • Select an item e.g. Item 1
    • Move focus using arrow keys, e.g. to Item 4
    • Close Dropdown using ESCAPE
    • Open Dropdown again using ENTER/SPACE
    • Item 4 is selected - That's a bug! It should still be latest selected Item, i.e. Item 1
  • When opening, move focus to selected index (if any)
  • Fix failing tests
  • Fix focus styles on mobile UPDATE: May already be solved
  • Fix Right Aligned example
  • Fix using Home and End keys (they still select when they shouldn't)
  • Fix arrow up/down when dropdown opens upwards - should focus bottom item when arrow up
  • Fix dropdown with scroll - selection disappears, then returns if you continue long enough (maybe Safari only?)
  • [BUG] Dropdown pre-selected checkmark is missing #2444
  • CSS: How can Ionics custom properties best be utilized?
  • Consolidate solution

Existing bugs

@jkaltoft jkaltoft moved this from 🚀 In Progress to 💤 Impeeded in Kirby Aug 30, 2022
@jkaltoft jkaltoft moved this from 💤 Impeeded to 🚀 In Progress in Kirby Sep 12, 2022
@jkaltoft
Copy link
Collaborator

I suggest we postpone this feature until v7.1.0. There seems to be a lot of things that sort of breaks and need fixing when rewriting the Dropdown component. Even though it is very related to v7.0.0 interaction state features we should take the time to improve the Dropdown properly - without postponing the release of v7.0.0.

@jkaltoft jkaltoft moved this from 🚀 In Progress to 💤 Impeeded in Kirby Sep 14, 2022
@jkaltoft jkaltoft assigned mark-drastrup and unassigned jkaltoft Sep 21, 2022
@jkaltoft jkaltoft moved this from 💤 Impeeded to 🚀 In Progress in Kirby Sep 21, 2022
@mark-drastrup mark-drastrup moved this from 🚀 In Progress to 🔎 Review pending in Kirby Sep 26, 2022
@jkaltoft jkaltoft moved this from 🔎 Review pending to 👀 Review in progess in Kirby Sep 26, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants