-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable keyboard navigation in the dropdown #2424
Enable keyboard navigation in the dropdown #2424
Conversation
723a30c
to
b45242c
Compare
b45242c
to
533f825
Compare
35f5389
to
d30c089
Compare
ebca8d1
to
c7df88e
Compare
37ad2a0
to
589bb79
Compare
c7df88e
to
7d380f2
Compare
7d380f2
to
af2fcbf
Compare
af2fcbf
to
49dcc0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
However, you should get someone else to approve the PR since I contributed some of the initial changes 😁
Don't forget to change the PR title - also see https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Pull-request for more good stuff 🤓
libs/designsystem/src/lib/components/dropdown/dropdown-popover.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/src/lib/components/dropdown/dropdown.component.scss
Outdated
Show resolved
Hide resolved
@RasmusKjeldgaard I have added some tests to check for the arrow key behaviour like we discussed 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one very minor comment
Which issue does this PR close?
This PR closes #2342
What is the new behavior?
Enabling navigation with the arrow keys in the dropdown on desktop. Additionally, it's possible to use tap to focus the dropdown and open it with enter or space.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.