Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable keyboard navigation in the dropdown #2424

Merged
merged 32 commits into from
Oct 14, 2022

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Aug 16, 2022

Which issue does this PR close?

This PR closes #2342

What is the new behavior?

Enabling navigation with the arrow keys in the dropdown on desktop. Additionally, it's possible to use tap to focus the dropdown and open it with enter or space.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jkaltoft jkaltoft changed the base branch from develop to feature/2236-change-background-color-on-focus August 16, 2022 14:44
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from 723a30c to b45242c Compare August 17, 2022 07:52
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 17, 2022 07:57 Inactive
Base automatically changed from feature/2236-change-background-color-on-focus to release/v7.0.0 August 17, 2022 09:12
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from b45242c to 533f825 Compare August 17, 2022 09:13
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 17, 2022 09:17 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 22, 2022 20:31 Inactive
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from 35f5389 to d30c089 Compare August 24, 2022 11:00
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 24, 2022 11:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 24, 2022 11:05 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 24, 2022 11:23 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 24, 2022 13:50 Inactive
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from ebca8d1 to c7df88e Compare August 25, 2022 12:51
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation August 25, 2022 12:55 Inactive
@jkaltoft jkaltoft changed the base branch from release/v7.0.0 to develop August 30, 2022 11:19
@jkaltoft jkaltoft changed the base branch from develop to release/v7.0.0 August 30, 2022 11:19
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from c7df88e to 7d380f2 Compare September 12, 2022 13:40
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation September 12, 2022 13:45 Inactive
Base automatically changed from release/v7.0.0 to develop September 16, 2022 12:25
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from 7d380f2 to af2fcbf Compare September 16, 2022 12:45
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation September 16, 2022 12:51 Inactive
@jkaltoft jkaltoft force-pushed the feature/2342-dropdown-keyboard-navigation branch from af2fcbf to 49dcc0e Compare September 20, 2022 09:59
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation September 20, 2022 10:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation September 23, 2022 12:23 Inactive
@mark-drastrup mark-drastrup marked this pull request as ready for review September 26, 2022 07:21
Copy link
Collaborator Author

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

However, you should get someone else to approve the PR since I contributed some of the initial changes 😁

Don't forget to change the PR title - also see https://github.com/kirbydesign/designsystem/wiki/The-Good%3A-Pull-request for more good stuff 🤓

@mark-drastrup mark-drastrup changed the title Feature/2342 dropdown keyboard navigation Enable keyboard navigation in the dropdown Sep 26, 2022
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation October 4, 2022 08:00 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation October 6, 2022 19:41 Inactive
@mark-drastrup
Copy link
Contributor

@RasmusKjeldgaard I have added some tests to check for the arrow key behaviour like we discussed 🙂

@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation October 11, 2022 07:43 Inactive
@github-actions github-actions bot temporarily deployed to pr-2342-dropdown-keyboard-navigation October 12, 2022 12:35 Inactive
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one very minor comment

@mark-drastrup mark-drastrup merged commit 67f07cb into develop Oct 14, 2022
@mark-drastrup mark-drastrup deleted the feature/2342-dropdown-keyboard-navigation branch October 14, 2022 06:59
@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown keyboard navigation selects an option
3 participants