Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FAB sheet not automatically closing when inner action item is clicked #2457

Closed
9 tasks
chfl-jyskebank-dk opened this issue Sep 6, 2022 · 0 comments · Fixed by #2472
Closed
9 tasks
Assignees
Labels
bug NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild

Comments

@chfl-jyskebank-dk
Copy link

Describe the bug

When interacting/clicking any menu item in the fab sheet menu, the fab sheet doesn't automatically close itself.

Describe how to reproduce the bug

  1. Go to https://cookbook.kirby.design/#/home/showcase/fab-sheet
  2. Be in a browser or device context - doesn't really matter
  3. Find and click on fab sheet in bottom right corner
  4. Click any of the inner menu items
  5. Observe how a toast is triggered, but the fab sheet still remains open

Which Kirby version was used?

  • Kirby v.7.xxx
  • Whatever version the cookbook uses

What was the expected behavior?

When a menu item is clicked within the fab sheet, the fab sheet is expected to automatically close itself.

Add any screenshots

No screenshots needed.

Please complete the following information:

  • OS: iPhone 12 mini
  • Browser Chrome
  • Browser version 104.0.5112.101

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@chfl-jyskebank-dk chfl-jyskebank-dk added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Sep 6, 2022
@RasmusKjeldgaard RasmusKjeldgaard changed the title FAB sheet not automatically closing when inner action item is clicked [BUG] [BUG] FAB sheet not automatically closing when inner action item is clicked Sep 6, 2022
@alxzak alxzak added this to Kirby Sep 6, 2022
@mictro mictro self-assigned this Sep 8, 2022
@mictro mictro moved this to 🚀 In Progress in Kirby Sep 8, 2022
@mictro mictro moved this from 🚀 In Progress to 🔎 Review pending in Kirby Sep 19, 2022
@alxzak alxzak removed the NOT Prioritized Issue not yet prioritized and added to a Milestone label Sep 27, 2022
Repository owner moved this from 🔎 Review pending to ✅ Done in Kirby Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants