Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no automatic close of fab-sheet on item click. #2472

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Fix no automatic close of fab-sheet on item click. #2472

merged 4 commits into from
Oct 24, 2022

Conversation

mictro
Copy link
Contributor

@mictro mictro commented Sep 9, 2022 •
edited
Loading

Which issue does this PR close?

This PR closes #2457

What is the new behavior?

Fix fab-sheet not closing when action item is selected.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • [] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mictro mictro changed the title Add close of fab on fab-list click Fix no automatic close of fab-sheet on item click. Sep 9, 2022
@mictro mictro force-pushed the bug/2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked branch from 3c6cc92 to 9fd689c Compare September 9, 2022 10:50
@github-actions github-actions bot temporarily deployed to pr-2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked September 9, 2022 10:52 Inactive
@github-actions github-actions bot temporarily deployed to pr-2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked September 9, 2022 10:54 Inactive
@mictro mictro closed this Sep 19, 2022
@mictro mictro force-pushed the bug/2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked branch from 9fd689c to 287254e Compare September 19, 2022 10:49
@mictro mictro reopened this Sep 19, 2022
@mictro mictro self-assigned this Sep 19, 2022
@github-actions github-actions bot temporarily deployed to pr-2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked September 19, 2022 11:30 Inactive
@github-actions github-actions bot had a problem deploying to pr-2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked September 19, 2022 11:30 Failure
@github-actions github-actions bot temporarily deployed to pr-2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked September 19, 2022 11:34 Inactive
RasmusKjeldgaard
RasmusKjeldgaard approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work like a charm, and awesome refactor too 👍

@mictro mictro enabled auto-merge October 24, 2022 13:00
@mictro mictro removed the request for review from jkaltoft October 24, 2022 13:05
@mictro mictro merged commit d9d7b4f into develop Oct 24, 2022
@mictro mictro deleted the bug/2457-fab-sheet-not-automatically-closing-when-inner-action-item-is-clicked branch October 24, 2022 13:05
@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard approved these changes

Assignees

@mictro mictro

Labels
bug component:FAB Sheet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] FAB sheet not automatically closing when inner action item is clicked
2 participants
@mictro @RasmusKjeldgaard