Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] New icons in Kirby #2476

Closed
1 of 11 tasks
henrikvoetmand opened this issue Sep 9, 2022 · 2 comments · Fixed by #2504
Closed
1 of 11 tasks

[Enhancement] New icons in Kirby #2476

henrikvoetmand opened this issue Sep 9, 2022 · 2 comments · Fixed by #2504
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers NOT Tech refined Needs Tech kickoff - solution outlined and agreed 🟢 Ready for release

Comments

@henrikvoetmand
Copy link
Collaborator

Describe the enhancement

We are working towards that all icons should be located in Kirby...

Describe the solution you'd like

Upload attached icons to Kirby and add the icons to Cookbook icon page.

Have you considered any alternatives?

No

Are there any additional context?

help-decoration
information-decoration
notification
transfer-ownership


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Sep 9, 2022
@alxzak alxzak added this to Kirby Sep 12, 2022
@alxzak alxzak removed 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone labels Sep 12, 2022
@RasmusKjeldgaard RasmusKjeldgaard added the good first issue Good for newcomers label Sep 19, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this to 📙 Backlog in Kirby Sep 22, 2022
@jkaltoft
Copy link
Collaborator

jkaltoft commented Sep 23, 2022

@henrikvoetmand can you provide names for the icons?

Unless you want to rely on @AgreSanGit to decide them. Just a heads up: He's pretty random in his choice of emojis, so who knows how creative he can be with icon names 😁.

Image

(Guess who added the last 3)

@henrikvoetmand
Copy link
Collaborator Author

help-decoration
information-decoration
notification
transfer-ownership

@AgreSanGit AgreSanGit moved this from 📙 Backlog to 🔎 Review pending in Kirby Sep 27, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review pending to 👀 Review in progess in Kirby Sep 29, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers NOT Tech refined Needs Tech kickoff - solution outlined and agreed 🟢 Ready for release
Projects
Archived in project
5 participants