Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new icons in kirby #2504

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Conversation

AgreSanGit
Copy link
Contributor

@AgreSanGit AgreSanGit commented Sep 27, 2022

Which issue does this PR close?

This PR closes #2476

What is the new behavior?

Added four new icons and updated cookbook with the new icons

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit changed the title Enhancement/2476 new icons in kirby v3 Added new icons in kirby Sep 27, 2022
@AgreSanGit AgreSanGit marked this pull request as ready for review September 27, 2022 08:37
@github-actions github-actions bot temporarily deployed to pr-2476-new-icons-in-kirby-v3 September 27, 2022 08:37 Inactive
@github-actions github-actions bot temporarily deployed to pr-2476-new-icons-in-kirby-v3 September 27, 2022 08:40 Inactive
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

giphub

@AgreSanGit AgreSanGit merged commit 18593ae into develop Sep 29, 2022
@AgreSanGit AgreSanGit deleted the enhancement/2476-new-icons-in-kirby-v3 branch September 29, 2022 10:07
@jkaltoft jkaltoft mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] New icons in Kirby
2 participants