Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add localization/translation of internal labels #3694

Closed
1 of 11 tasks
RasmusKjeldgaard opened this issue Nov 4, 2024 · 0 comments · Fixed by #3717
Closed
1 of 11 tasks

[Enhancement] Add localization/translation of internal labels #3694

RasmusKjeldgaard opened this issue Nov 4, 2024 · 0 comments · Fixed by #3717
Assignees
Labels
enhancement New feature or request

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Nov 4, 2024

Describe the enhancement

Some labels and text content inside components should have proper translations according to our supported locale.
For instance, the previous/next month buttons of kirby-calendar or the close button of the modal are hidden from consumers of the component, and we should add a sensible translation.

Describe the solution you'd like

Should be researched! Shoelace has some considerations that are worth exploring: https://shoelace.style/getting-started/localization

Have you considered any alternatives?

If we choose to bake in the translations, consumers will not have to import translation assets into their own projects, and configure kirby. It will just work out of the box.
But a trade-off is that new or custom translations cannot be added easily by projects. Consider adding an option to override the default translations per locale.

Are there any additional context?

This is an initial list of identified translations:

  • Calendar
    • Previous month
    • Next month
    • Year navigator
  • Page back button
  • Slides
    • Previous slide
    • Next slide
  • Modal
    • Close
    • Supplementary action

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Nov 4, 2024
@github-project-automation github-project-automation bot moved this to 📙 Backlog in Kirby Nov 4, 2024
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Nov 19, 2024
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Nov 19, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🚀 In Progress to 🔎 Review Pending in Kirby Dec 3, 2024
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review Pending to 👀 Review In Progress in Kirby Dec 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 Review In Progress to ✅ Done in Kirby Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant