[Enhancement] Allow for Image Banner to be used in Slides with slideStretchHeight enabled #3712
Labels
enhancement
New feature or request
👶🏻 New
For new issues before prioritisation and refinement
NOT Prioritized
Issue not yet prioritized and added to a Milestone
NOT Tech refined
Needs Tech kickoff - solution outlined and agreed
Describe the enhancement
Using slideStretchHeight with
kirby-x-image-banner
makes the host element the correct height, however thekirby-card
inside will not grow vertically to fill the kirby-x-image-banner element.Describe the solution you'd like
Simply adding the css property height:100% to the selector
kirby-card
could solve this problem.Have you considered any alternatives?
I haven't thought of any. I was trying to solve it with the css variable min-height that was recently introduced, but that property targets an element way in there. Maybe that could be refactored to work on the kirby-card instead.
Are there any additional context?
As is
Wanted
This is achieved as of right now with the following (but unwanted due to deprecation of ng-deep)
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Refinement
Implementation
When were settled on a solution I would gladly do the PR.
The contributor who wants to implement this issue should:
Review
Once the issue has been implemented and is ready for review:
The text was updated successfully, but these errors were encountered: