Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Banner: make card same height as parent #3716

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Nov 20, 2024

Which issue does this PR close?

This PR closes #3712

What is the new behavior?

The nested card always grows to 100% of the image-banner, so it can be controlled from the otuside by setting the image banner height.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

Copy link
Collaborator

@troelslenda troelslenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RasmusKjeldgaard RasmusKjeldgaard changed the title Image Banner: make card same height as image-banner Image Banner: make card same height as parent Nov 20, 2024
@Fuzzy3 Fuzzy3 merged commit ab0e31b into develop Nov 20, 2024
9 checks passed
@Fuzzy3 Fuzzy3 deleted the enhancement/3712-card-height-in-slider branch November 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Allow for Image Banner to be used in Slides with slideStretchHeight enabled
3 participants