Only prevent touchevent outside popover #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
pr-2204-dropdown-popover-not-scrollable
jkaltoft
previously approved these changes
Apr 28, 2022
github-actions
bot
temporarily deployed
to
pr-2204-dropdown-popover-not-scrollable
This is to avoid future problems if 'this' is referred within the callback down the line.
github-actions
bot
temporarily deployed
to
pr-2204-dropdown-popover-not-scrollable
jkaltoft
approved these changes
Apr 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2204
What is the new behavior?
We make sure to check that we are not actually scrolling inside the popover, before we prevent the touchmove event.
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be automatically merged to
stablevia automerge.