Fix item-selection on dropdown with popover in safari #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
pr-7114-use-popover-on-select-dropdowns
mictro
force-pushed
the
bug/7114-use-popover-on-select-dropdowns
branch
from
be58be9 to
a64170e
Compare
mictro
force-pushed
the
bug/7114-use-popover-on-select-dropdowns
branch
from
a64170e to
b8d94c4
Compare
mictro
changed the title
mictro
changed the title
MadsBuchmann
suggested changes
Jun 17, 2022
There was a problem hiding this comment.
Got some minor comments and it seems like there are failing tests.
In the long run i really think we should be looking into using ionics popover functionality instead of our own homebrewed concoction.
libs/designsystem/src/lib/components/dropdown/dropdown.component.ts
Outdated
Show resolved
Hide resolved
| @@ -471,14 +471,19 @@ export class DropdownComponent | |||
|
|
|||
| @HostListener('keydown.enter') | |||
| @HostListener('keydown.escape') | |||
| _onEnterOrEsscape(event?: FocusEvent) { | |||
There was a problem hiding this comment.
I'm getting the following linting error on this line:
[tsserver 6133] [I] 'event' is declared but its value is never read.
| this._onTouched(); | ||
| } | ||
|
|
||
| _onPopoverClick(event: PointerEvent) { |
There was a problem hiding this comment.
I'm getting the following linting error on this line:
[tsserver 6133] [I] 'event' is declared but its value is never read.
| _onPopoverClick(event: PointerEvent) { | ||
| this.close(); | ||
| } | ||
|
|
||
| @HostListener('blur', ['$event']) | ||
| _onBlur(event?: FocusEvent) { |
There was a problem hiding this comment.
I'm getting the following linting error on this line:
[tsserver 6133] [I] 'event' is declared but its value is never read.
mictro
force-pushed
the
bug/7114-use-popover-on-select-dropdowns
branch
from
e995dcc to
04138ba
Compare
github-actions
bot
temporarily deployed
to
pr-7114-use-popover-on-select-dropdowns
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2317
What is the new behavior?
Fix selection problem on dropdown with popover in Safari/WebView.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.