Allow flag notification colors to be overridden #2361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CSS custom property instead of color value to make it possible.
Fixes #2353
Which issue does this PR close?
This PR closes # (insert issue number here)
What is the new behavior?
success
andwarning
notification colors for<kirby-flag>
can be overridden in consumer projects.Does this PR introduce a breaking change?
Are there any additional context?
danger
notification color for flags is a special case and cannot be controlled by consumer project by overriding the custom property--kirby-danger
.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.