Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flag notification colors to be overridden #2361

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Jun 21, 2022

Use CSS custom property instead of color value to make it possible.

Fixes #2353

Which issue does this PR close?

This PR closes # (insert issue number here)

What is the new behavior?

success and warning notification colors for <kirby-flag> can be overridden in consumer projects.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

danger notification color for flags is a special case and cannot be controlled by consumer project by overriding the custom property --kirby-danger .

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

Use CSS custom property instead of color value to make it possible.

Fixes #2353
@github-actions github-actions bot temporarily deployed to pr-2353-wrong-color-on-flag June 21, 2022 14:08 Inactive
@jkaltoft jkaltoft changed the title 🐛 Allow flag notification colors to be overridden Allow flag notification colors to be overridden Jun 21, 2022
@jkaltoft jkaltoft marked this pull request as ready for review June 21, 2022 14:12
@github-actions github-actions bot temporarily deployed to pr-2353-wrong-color-on-flag June 23, 2022 13:07 Inactive
@jkaltoft jkaltoft merged commit f4dfdc2 into develop Jun 24, 2022
@jkaltoft jkaltoft deleted the bug/2353-wrong-color-on-flag branch June 24, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong Color on flag
2 participants