Calculate line-height to control total flag height #2365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1904
Which issue does this PR close?
This PR closes # (insert issue number here)
What is the new behavior?
The intrinsic height of a Flag (or any element) is defined by its font-size, vertical padding, border width and line height. By calculating the line-height we can control the total height of a Flag and make it match a defined target height.
Does this PR introduce a breaking change?
Are there any additional context?
The difference is subtle but here it is:
Before
After
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.