Fix chart.js plugins imported as defaults not loading #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shipped package.json file located in the designsystem library was different from the one in the root package.json that is used for development.
In the context of DRB the annotationPlugin & ChartDataLabels plugin is loaded as objects where the actual value expected by register is located in the default field. It is possible to check the __esModule field of the plugin to see if it is necessary.
github-actions
bot
temporarily deployed
to
pr-xxxx-chart-js-plugins-not-loading
RasmusKjeldgaard
approved these changes
Jun 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes no issue
What is the new behavior?
Does this PR introduce a breaking change?
Are there any additional context?
In DRB the chart.js plugins that are imported as defaults are not loaded.
When the
CHART_PLUGINSarray is printed it reveals that the plugins are wrapped in an object:Therefore the fix for now is to unwrap it if that is the case. More work is needed to determine why this happens in the consumer project however.
Furthermore the chart.js version used for development has been aligned with the one shipped in
libs/designsystem/package.json.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
developby Team Kirby.