Fix slotted items being unclickable after update #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2153 - the issue was caused by the event listener being set up once using the renderer on afterContentChecked. If the slotted items changed an if sentence did so the new items did not have their click listener set up. Now we do it everytime the kirbyItemsSlotted attribute is updated. We also make sure to unlisten old items when it changes & onDestroy.
MadsBuchmann
changed the title
MadsBuchmann
changed the title
jkaltoft
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2153
What is the new behavior?
The issue was caused by the event listener being set up once using the renderer on afterContentChecked. If the slotted items changed, an if sentence caused the new items to not have their click listener set up. Now we do it everytime the kirbyItemsSlotted attribute is updated. We also make sure to unlisten old items when it changes & onDestroy.
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Review
Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
developby Team Kirby.